The 50 Essential Movie Musicals site is true to its name: It lists what is arguably the 50 best movie musicals, excluding obvious failures and including successful films, whether popular or not. Each listed film has the trailer and information with it.
Check it out, from All That Jazz to The Wizard of Oz, read the many comments, and then add what you think is missing.